ohnoitsyou commented on code in PR #7242:
URL: https://github.com/apache/nifi/pull/7242#discussion_r1212209884


##########
nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java:
##########
@@ -111,6 +115,9 @@ public StatelessEngineConfiguration 
parseEngineConfiguration(final File properti
 
         final String statusTaskInterval = 
properties.getProperty(STATUS_TASK_INTERVAL, "1 min");
 
+        final long processorStartTimeout = 
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(PROCESSOR_START_TIMEOUT,
 "10")));
+        final long componentEnableTimeout = 
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(COMPONENT_ENABLE_TIMEOUT,
 "10")));

Review Comment:
   @markap14 After a quick chat with David H. I brought up that FormatUtils is 
located within `nifi-utils` which is something stateless doesn't already 
import. What would be your opinion on including this? If the answer is "don't", 
how would you recommend converting from strings to `Duration`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to