markap14 commented on code in PR #7242:
URL: https://github.com/apache/nifi/pull/7242#discussion_r1213160327
##########
nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java:
##########
@@ -111,6 +115,9 @@ public StatelessEngineConfiguration
parseEngineConfiguration(final File properti
final String statusTaskInterval =
properties.getProperty(STATUS_TASK_INTERVAL, "1 min");
+ final long processorStartTimeout =
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(PROCESSOR_START_TIMEOUT,
"10")));
+ final long componentEnableTimeout =
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(COMPONENT_ENABLE_TIMEOUT,
"10")));
Review Comment:
So it's okay to bring `nifi-utils` into `nifi-stateless-engine`. Definitely
not ok to bring it into `nifi-stateless-api` though. So we should probably have
the `StatelessEngineConfiguration` return a `String` representation instead of
a `Duration`. Then, do the conversion in the `nifi-stateless-engine` module
where it'll be used.
It probably actually makes sense to move the FormatUtils functionality into
nifi-api because there have been other places where it'd be nice to have it
available, such as directly in NiFiProperties. But that's beyond the scope of
this Jira :) But something to consider for NiFi 2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
