exceptionfactory commented on code in PR #7242:
URL: https://github.com/apache/nifi/pull/7242#discussion_r1213217799
##########
nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java:
##########
@@ -111,6 +115,9 @@ public StatelessEngineConfiguration
parseEngineConfiguration(final File properti
final String statusTaskInterval =
properties.getProperty(STATUS_TASK_INTERVAL, "1 min");
+ final long processorStartTimeout =
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(PROCESSOR_START_TIMEOUT,
"10")));
+ final long componentEnableTimeout =
TimeUnit.SECONDS.toMillis(Long.parseLong(properties.getProperty(COMPONENT_ENABLE_TIMEOUT,
"10")));
Review Comment:
Thanks for the summary @markap14, the FormatUtils has some deprecated
methods that need to be removed for NiFi 2.0, and I could see value in pulling
it out of `nifi-utils` and into `nifi-api`. In the meantime, it sounds like
having the Configuration method return a String value and doing the conversion
elsewhere is the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
