dam4rus commented on code in PR #7338:
URL: https://github.com/apache/nifi/pull/7338#discussion_r1230007521
##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/DatabaseMetadataService.java:
##########
@@ -391,8 +391,12 @@ public FlowSnapshotEntity getFlowSnapshot(final String
flowIdentifier, final Int
@Override
public FlowSnapshotEntity getLatestSnapshot(final String flowIdentifier) {
- final String sql = "SELECT * FROM FLOW_SNAPSHOT WHERE flow_id = ?
ORDER BY version DESC LIMIT 1";
-
+ final String sql;
+ if (jdbcTemplate.getDataSource() instanceof OracleCommonDataSource) {
Review Comment:
@bbende Even though I agree that the best solution would be an ORM or a new
layer, I'm not sure it should be in the scope of this PR (or in the MSSQL
PR's). There would be many conflict for #7245 if this is merged first and
vice-versa. We've basically implemented the same things with a different
approach already. Maybe it would be worth considering the proper abstraction
and merging it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
