bbende commented on code in PR #7338:
URL: https://github.com/apache/nifi/pull/7338#discussion_r1230033355
##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/DatabaseMetadataService.java:
##########
@@ -391,8 +391,12 @@ public FlowSnapshotEntity getFlowSnapshot(final String
flowIdentifier, final Int
@Override
public FlowSnapshotEntity getLatestSnapshot(final String flowIdentifier) {
- final String sql = "SELECT * FROM FLOW_SNAPSHOT WHERE flow_id = ?
ORDER BY version DESC LIMIT 1";
-
+ final String sql;
+ if (jdbcTemplate.getDataSource() instanceof OracleCommonDataSource) {
Review Comment:
Yes, sorry I did not mean that this PR should introduce an ORM or
abstraction layer. I meant that maybe we should take a step back and consider
what options we have for producing DB specific SQL, and try to put that in
place before we move forward with Oracle or MSSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
