dam4rus commented on code in PR #7338:
URL: https://github.com/apache/nifi/pull/7338#discussion_r1230479039
##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/DatabaseMetadataService.java:
##########
@@ -391,8 +391,12 @@ public FlowSnapshotEntity getFlowSnapshot(final String
flowIdentifier, final Int
@Override
public FlowSnapshotEntity getLatestSnapshot(final String flowIdentifier) {
- final String sql = "SELECT * FROM FLOW_SNAPSHOT WHERE flow_id = ?
ORDER BY version DESC LIMIT 1";
-
+ final String sql;
+ if (jdbcTemplate.getDataSource() instanceof OracleCommonDataSource) {
Review Comment:
@mattyb149 No, they are not only for the tests. These sql queries are
executed via some REST API calls and that's why they were eluded during my
initial manual testing.
@bbende No, I'm sorry because I've just misinterpreted your comment. Sounds
good to me.
@exceptionfactory I've actually got rid of directly depending on Oracle.
Even though this PR won't be merged as it is I'll push my recent commit to fix
that and be more consistent with #7245 by using Flyway instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
