[
https://issues.apache.org/jira/browse/NIFI-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709061#comment-15709061
]
ASF GitHub Bot commented on NIFI-3093:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1281#discussion_r90272836
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
---
@@ -186,8 +186,10 @@ public void onTrigger(final ProcessContext context,
final ProcessSessionFactory
try (final Connection con = dbcpService.getConnection();
final Statement st = con.createStatement()) {
- final Integer queryTimeout =
context.getProperty(QUERY_TIMEOUT).asTimePeriod(TimeUnit.SECONDS).intValue();
- st.setQueryTimeout(queryTimeout); // timeout in seconds
+ if(dbAdapter.getSupportsStatementTimeout()) {
--- End diff --
This makes sense to me, but when we were talking about supporting Hive in
ExecuteSQL, there were concerns about those drivers that don't support
statement timeouts, which is one reason why there's a separate Hive NAR (and
Select/PutHiveQL processors). This was before DatabaseAdapter came along, so
perhaps now this can be alleviated as you've done here. Does this work when
using a HiveConnectionPool? Or are you using a DBCPConnectionPool that points
to Hive JARs? It seems like if this works with a HiveConnectionPool (with your
changes to JdbcCommon below), then the Select/PutHiveQL processors could be
deprecated.
> HIVE Support for QueryDatabaseTable
> -----------------------------------
>
> Key: NIFI-3093
> URL: https://issues.apache.org/jira/browse/NIFI-3093
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Peter Wicks
> Assignee: Peter Wicks
>
> Update Query Database Table so that it can pull data from HIVE tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
