[ 
https://issues.apache.org/jira/browse/NIFI-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709067#comment-15709067
 ] 

ASF GitHub Bot commented on NIFI-3093:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1281#discussion_r90273518
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JdbcCommon.java
 ---
    @@ -284,7 +291,7 @@ public static Schema createSchema(final ResultSet rs, 
String recordName, boolean
                         break;
     
                     case INTEGER:
    -                    if (meta.isSigned(i)) {
    +                    if (!dbAdapter.getSupportsMetaDataColumnIsSigned() || 
meta.isSigned(i)) {
    --- End diff --
    
    If the DB doesn't support isSigned(), should we treat them all as Longs? I 
assume it's done this way if Hive returns INTEGER as the type and Integer 
objects for values. I wonder if there's another DB that doesn't support 
isSigned() and could return Long objects. In that case we might want another 
check for getSupportsMetaDataColumnIsSigned() (and for the type of object) when 
storing the values into the record.


> HIVE Support for QueryDatabaseTable
> -----------------------------------
>
>                 Key: NIFI-3093
>                 URL: https://issues.apache.org/jira/browse/NIFI-3093
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.2.0
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>
> Update Query Database Table so that it can pull data from HIVE tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to