[ 
https://issues.apache.org/jira/browse/NIFI-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709136#comment-15709136
 ] 

ASF GitHub Bot commented on NIFI-3093:
--------------------------------------

Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1281#discussion_r90279351
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JdbcCommon.java
 ---
    @@ -300,7 +307,7 @@ public static Schema createSchema(final ResultSet rs, 
String recordName, boolean
                         // Check the precision of the BIGINT. Some databases 
allow arbitrary precision (> 19), but Avro won't handle that.
                         // If the precision > 19 (or is negative), use a 
string for the type, otherwise use a long. The object(s) will be converted
                         // to strings as necessary
    -                    int precision = meta.getPrecision(i);
    +                    int precision = 
dbAdapter.getSupportsMetaDataColumnGetPrecision()?meta.getPrecision(i):0;
    --- End diff --
    
    Probably `-1` would be a safer choice. If we can't retrieve precision, and 
especially since HIVE supports up to Decimal 38... we don't want to 
accidentally lose data or start throwing exceptions for overflows.


> HIVE Support for QueryDatabaseTable
> -----------------------------------
>
>                 Key: NIFI-3093
>                 URL: https://issues.apache.org/jira/browse/NIFI-3093
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.2.0
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>
> Update Query Database Table so that it can pull data from HIVE tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to