lordgamez commented on code in PR #1598:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1598#discussion_r1251961829
##########
cmake/BuildTests.cmake:
##########
@@ -30,6 +30,16 @@ ENDMACRO()
set(NANOFI_TEST_DIR "${CMAKE_SOURCE_DIR}/nanofi/tests/")
+function(configureTestResources SOURCE_DIR DEST_DIR)
Review Comment:
As it doesn't do any configuration maybe it should be named something like
`copyTestResources`
##########
libminifi/CMakeLists.txt:
##########
@@ -78,7 +78,7 @@ endif()
file(GLOB PROCESSOR_SOURCES "src/processors/*.cpp" )
-add_library(core-minifi SHARED ${SOURCES})
+add_library(core-minifi SHARED ${SOURCES} include/utils/net/AsioSocketUtils.h)
Review Comment:
Is include/utils/net not included in the include directories or why is it
needed to be added to the sources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
