martinzink commented on code in PR #1598:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1598#discussion_r1281626511


##########
libminifi/test/unit/NetUtilsTest.cpp:
##########
@@ -64,3 +65,44 @@ TEST_CASE("net::reverseDnsLookup", 
"[net][dns][reverseDnsLookup]") {
     CHECK(unresolvable_hostname == "2001:db8::");
   }
 }
+
+TEST_CASE("utils::net::getClientSslContext") {
+  TestController controller;
+  auto plan = controller.createPlan();
+
+  auto ssl_context_node = plan->addController("SSLContextService", 
"ssl_context_service");
+  auto ssl_context_service = 
std::dynamic_pointer_cast<minifi::controllers::SSLContextService>(ssl_context_node->getControllerServiceImplementation());
+
+  const std::filesystem::path ca_dir = 
std::filesystem::path(minifi::utils::file::FileUtils::get_executable_dir()) / 
"resources";

Review Comment:
   good idea, changed it to cert_dir in 
https://github.com/apache/nifi-minifi-cpp/pull/1598/commits/4520d969e058763ccee42197547b9993c8604f86#diff-a383222e204712d33628e58bf0e17c46f8480d366677941aaca4c4743747126fL76



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to