martinzink commented on code in PR #1598:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1598#discussion_r1281629795


##########
libminifi/test/unit/NetUtilsTest.cpp:
##########
@@ -64,3 +65,44 @@ TEST_CASE("net::reverseDnsLookup", 
"[net][dns][reverseDnsLookup]") {
     CHECK(unresolvable_hostname == "2001:db8::");
   }
 }
+
+TEST_CASE("utils::net::getClientSslContext") {

Review Comment:
   Added some tests that deal with passphrase problems and one that deals with 
missing CA the later one also revealed a problem (CA is not required in 
SSLContextService, so we should check if its there before setting into the asio 
ssl_context) 
https://github.com/apache/nifi-minifi-cpp/pull/1598/commits/4520d969e058763ccee42197547b9993c8604f86#diff-a383222e204712d33628e58bf0e17c46f8480d366677941aaca4c4743747126fR110-R158



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to