szaszm commented on code in PR #1623:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1623#discussion_r1281790474
##########
cmake/GoogleCloudCpp.cmake:
##########
@@ -66,3 +66,5 @@ if (WIN32)
else()
target_compile_options(google_cloud_cpp_storage PUBLIC
-Wno-error=deprecated-declarations)
endif()
+
+target_compile_options(google_cloud_cpp_rest_internal PUBLIC -Wno-error)
Review Comment:
I think this should go in a similar platform check as above, since
`-Wno-error` is not a valid MSVC flag.
##########
thirdparty/libwebsockets/enum-int.patch:
##########
Review Comment:
Can we patch libwebsockets to use our own OpenSSL build?
##########
.github/workflows/gcc13-compat.yml:
##########
@@ -0,0 +1,46 @@
+name: "MiNiFi-CPP verify gcc13 compatibility"
+on: [workflow_dispatch]
+jobs:
+ ubuntu_22_04:
+ name: "ubuntu-22.04-gcc-13"
+ runs-on: ubuntu-22.04
+ timeout-minutes: 120
+ steps:
+ - id: checkout
+ uses: actions/checkout@v3
+ - id: install_deps
+ run: |
+ sudo apt update
+ sudo apt install -y ccache libfl-dev libpcap-dev libboost-all-dev
openjdk-8-jdk maven libusb-1.0-0-dev libpng-dev libgps-dev libsqliteodbc lua5.3
liblua5.3-dev flake8 parallel
+ echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
+ echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null
+ - name: build
+ run: |
+ eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
+ brew install gcc@13
Review Comment:
You can use the Toolchain test PPA to install GCC 13:
https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
