szaszm commented on code in PR #1623:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1623#discussion_r1288655860
##########
cmake/BundledAzureSdkCpp.cmake:
##########
@@ -55,14 +59,17 @@ function(use_bundled_libazure SOURCE_DIR BINARY_DIR)
set(AZURE_SDK_CMAKE_ARGS ${PASSTHROUGH_CMAKE_ARGS}
-DWARNINGS_AS_ERRORS=OFF
- -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR})
+ -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
+ -DDISABLE_AZURE_CORE_OPENTELEMETRY=ON
+ -DBUILD_TRANSPORT_CURL=ON
+ -DCMAKE_CXX_FLAGS=-DCURL_STATICLIB)
Review Comment:
Would it work if we used `target_compile_definitions` instead, or does that
not get passed down? Also, do we not need this definition when including Azure
SDK headers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
