lordgamez commented on code in PR #1623: URL: https://github.com/apache/nifi-minifi-cpp/pull/1623#discussion_r1286792619
########## thirdparty/libwebsockets/enum-int.patch: ########## Review Comment: The libwebsockets is using our openssl build. The goal of the `libwebsockets/openssl3.patch` is to not use the `CHECK_FUNCTION_EXISTS` functions for checking the availability of specific openssl functions as they try to find them on the system. As we want to use our own lib instead of the system provided one, we simply set those openssl functions to be available because they are provided by our openssl build. I thought the reason for the `thirdparty/libwebsockets/enum-int.patch` was to avoid a warning only occurring on GCC13 that's why I suggested disabling `Werror` on this third-party library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
