lordgamez commented on code in PR #1600:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1600#discussion_r1298515352
##########
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##########
@@ -400,9 +403,9 @@ TEST_CASE("PutTCP test missing client cert", "[PutTCP]") {
auto port = test_fixture.addSSLServer();
test_fixture.setPutTCPPort(port);
- trigger_expect_failure(test_fixture, "message for invalid-cert server");
+ test_fixture.trigger("message for invalid-cert server");
Review Comment:
When I tested it, it seemed the routing depended on if the message could be
sent before the server reset the connection. If it was reset before the message
was sent it resulted in failure otherwise the result was success. Unfortunately
in this processor we do not read through the connection, only write to the
socket, so we cannot know if the handshake succeeded or not using TLS 1.3 other
than the connection was reset or not while sending the message. We can document
this, but I do not see any other option how this could be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
