martinzink commented on code in PR #1600:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1600#discussion_r1298546201
##########
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##########
@@ -400,9 +403,9 @@ TEST_CASE("PutTCP test missing client cert", "[PutTCP]") {
auto port = test_fixture.addSSLServer();
test_fixture.setPutTCPPort(port);
- trigger_expect_failure(test_fixture, "message for invalid-cert server");
+ test_fixture.trigger("message for invalid-cert server");
Review Comment:
Yeah thats what I feared, without a more complex application layer we cant
gurantee anything.
Still a note could be useful to the user, but I am not sure where can we put
something like this.
The processor description seems a bit generic for a note like this, but
anything other than that will be overwritten by the doc generation. 🤷 Maybe a
code comment wil be sufficient?
##########
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##########
@@ -400,9 +403,9 @@ TEST_CASE("PutTCP test missing client cert", "[PutTCP]") {
auto port = test_fixture.addSSLServer();
test_fixture.setPutTCPPort(port);
- trigger_expect_failure(test_fixture, "message for invalid-cert server");
+ test_fixture.trigger("message for invalid-cert server");
Review Comment:
Yeah thats what I feared, without a more complex application layer we cant
gurantee anything.
Still a note could be useful to the user, but I am not sure where can we put
something like this.
The processor description seems a bit generic for a note like this, but
anything other than that will be overwritten by the doc generation. 🤷 Maybe a
code comment wil be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
