lordgamez commented on code in PR #1600:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1600#discussion_r1298520309
##########
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##########
@@ -400,9 +403,9 @@ TEST_CASE("PutTCP test missing client cert", "[PutTCP]") {
auto port = test_fixture.addSSLServer();
test_fixture.setPutTCPPort(port);
- trigger_expect_failure(test_fixture, "message for invalid-cert server");
+ test_fixture.trigger("message for invalid-cert server");
Review Comment:
The failure relationship is documented like this at the moment: "FlowFiles
that encountered IO errors are send out this relationship."
It does not say anything about the message arriving on the server or not,
and I think no IO errors are reported if the handshake fails so it can match
the current functionality, but I suppose it's better to add a note about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
