lordgamez opened a new pull request, #1661: URL: https://github.com/apache/nifi-minifi-cpp/pull/1661
CPP Core Guideline checks added (most issues fixed, marked the checks only introduced, but not fixed due to too many instances of the issue being present): cppcoreguidelines-prefer-member-initializer cppcoreguidelines-pro-type-member-init cppcoreguidelines-narrowing-conversions cppcoreguidelines-init-variables (not fixed) cppcoreguidelines-avoid-c-arrays (not fixed) cppcoreguidelines-avoid-goto cppcoreguidelines-pro-bounds-constant-array-index cppcoreguidelines-special-member-functions cppcoreguidelines-pro-type-vararg cppcoreguidelines-avoid-capturing-lambda-coroutines cppcoreguidelines-interfaces-global-init cppcoreguidelines-misleading-capture-default-by-value cppcoreguidelines-missing-std-forward cppcoreguidelines-no-malloc cppcoreguidelines-no-suspend-with-lock cppcoreguidelines-owning-memory cppcoreguidelines-pro-type-union-access cppcoreguidelines-rvalue-reference-param-not-moved cppcoreguidelines-slicing cppcoreguidelines-virtual-class-destructor cppcoreguidelines-macro-usage Checks not added due to not being fit to our practices or producing too many false positives: cppcoreguidelines-avoid-do-while cppcoreguidelines-avoid-non-const-global-variables cppcoreguidelines-pro-bounds-pointer-arithmetic cppcoreguidelines-avoid-magic-numbers cppcoreguidelines-pro-type-reinterpret-cast cppcoreguidelines-non-private-member-variables-in-classes cppcoreguidelines-avoid-const-or-ref-data-members cppcoreguidelines-pro-type-const-cast cppcoreguidelines-pro-type-static-cast-downcast cppcoreguidelines-avoid-reference-coroutine-parameters cppcoreguidelines-pro-type-cstyle-cast cppcoreguidelines-pro-bounds-array-to-pointer-decay https://issues.apache.org/jira/browse/MINIFICPP-2196 -------------------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
