szaszm commented on code in PR #1661:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1338040506
##########
extensions/expression-language/Expression.cpp:
##########
@@ -118,21 +118,21 @@ Value resolve_user_id(const std::vector<Value> &args) {
}
Value expr_hostname(const std::vector<Value> &args) {
- char hostname[1024];
+ std::array<char, 1024> hostname{};
hostname[1023] = '\0';
Review Comment:
The same applies to `hints`: After it's direct-list-initialized, `memset` to
zeroes is no longer necessary. But I don't mind either keeping or removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
