lordgamez commented on code in PR #1661:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1336864844
##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -42,10 +42,9 @@ namespace {
*/
optional<std::string> demangle_symbol(const char* symbol_name) {
int status;
- char* demangled = abi::__cxa_demangle(symbol_name, nullptr, nullptr,
&status);
+ std::unique_ptr<char> demangled(abi::__cxa_demangle(symbol_name, nullptr,
nullptr, &status));
Review Comment:
Good idea, updated in c7c57deb66f14433990fd21f6f1fe8ad7184d117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
