lordgamez commented on code in PR #1661:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1338792943
##########
extensions/librdkafka/KafkaConnection.cpp:
##########
@@ -69,8 +70,8 @@ void KafkaConnection::setConnection(gsl::owner<rd_kafka_t*>
producer) {
startPoll();
}
-rd_kafka_t *KafkaConnection::getConnection() const {
- return kafka_connection_;
+rd_kafka_t* KafkaConnection::getConnection() const {
+ return static_cast<rd_kafka_t*>(kafka_connection_);
Review Comment:
Clang tidy gives a warning as we return a gsl::owner<> type but the return
value does not reflect that. This way we make it explicit that we do not want
to move the ownership, only return the raw pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
