lordgamez commented on code in PR #1669:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1669#discussion_r1338875658
##########
controller/Controller.cpp:
##########
@@ -225,4 +227,43 @@ bool getJstacks(const utils::net::SocketData& socket_data,
std::ostream &out) {
return true;
}
+nonstd::expected<void, std::string> getDebugBundle(const
utils::net::SocketData& socket_data, const std::filesystem::path& target_dir) {
+ std::unique_ptr<io::BaseStream> connection_stream =
std::make_unique<utils::net::AsioSocketConnection>(socket_data);
Review Comment:
Unfortunately that doesn't compile due to the virtual inheritance in
InputStream and OutputStream classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
