lordgamez commented on code in PR #1669: URL: https://github.com/apache/nifi-minifi-cpp/pull/1669#discussion_r1338924083
########## libminifi/include/utils/file/ArchiveUtils.h: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <map> +#include <string> + +#include "io/ArchiveStream.h" +#include "utils/expected.h" +#include "io/BufferStream.h" + +namespace org::apache::nifi::minifi::utils::archive { + +nonstd::expected<std::shared_ptr<io::BufferStream>, std::string> createArchive(std::map<std::string, std::unique_ptr<io::InputStream>>& files, const std::shared_ptr<core::logging::Logger>& logger); Review Comment: I'm not sure we have to be this strict with the interface of a utility function, it may be enough to be as generic as our use cases require it to be, and shape the interface according to the new use cases of the function as required. There were some good points, I removed the unneeded logger and changed the `files` parameter to const ref, but as this can utility can be restricted to out C2 use cases I moved it to C2Utils and renamed it to `createDebugBundleArchive`. It can be modified and moved to a more generic utility file later if a new use cases arises. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
