martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1339867672


##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
@@ -100,7 +100,7 @@ void InvokeHTTP::setupMembersFromProperties(const 
core::ProcessContext& context)
   attributes_to_send_ = context.getProperty(AttributesToSend)
                         | utils::filter([](const std::string& s) { return 
!s.empty(); })  // avoid compiling an empty string to regex
                         | utils::transform([](const std::string& regex_str) { 
return utils::Regex{regex_str}; })
-                        | utils::orElse([this] { logger_->log_debug("%s is 
missing, so the default value will be used", 
std::string{AttributesToSend.name}); });
+                        | utils::orElse([this] { logger_->log_debug("{} is 
missing, so the default value will be used", 
std::string{AttributesToSend.name}); });

Review Comment:
   Good idea, I've missed these, Fixed in 
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/d3ef60e1d7b55ea9dec75719281745303c4e0bad



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to