martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342394026
##########
libminifi/include/utils/ResourceQueue.h:
##########
@@ -108,16 +108,16 @@ class ResourceQueue : public
std::enable_shared_from_this<ResourceQueue<Resource
private:
void returnResource(std::unique_ptr<ResourceType> resource) {
- logDebug("Returning [%p] resource", resource.get());
+ logDebug("Returning [{}] resource", static_cast<void*>(resource.get()));
if (reset_fn_)
reset_fn_.value()(*resource);
internal_queue_.enqueue(std::move(resource));
}
template<typename ...Args>
- void logDebug(const char * const format, Args&& ...args) {
+ void
logDebug(fmt::format_string<std::invoke_result_t<decltype(core::logging::map_args),
Args>...> fmt, Args&& ...args) {
if (logger_)
- logger_->log_debug(format, std::forward<Args>(args)...);
+ logger_->log_debug(fmt, std::forward<Args>(args)...);
Review Comment:
👍
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/1708a25c1b0cbeae6de94ea6ec74986a00a6d3e6
##########
libminifi/include/utils/ResourceQueue.h:
##########
@@ -108,16 +108,16 @@ class ResourceQueue : public
std::enable_shared_from_this<ResourceQueue<Resource
private:
void returnResource(std::unique_ptr<ResourceType> resource) {
- logDebug("Returning [%p] resource", resource.get());
+ logDebug("Returning [{}] resource", static_cast<void*>(resource.get()));
if (reset_fn_)
reset_fn_.value()(*resource);
internal_queue_.enqueue(std::move(resource));
}
template<typename ...Args>
- void logDebug(const char * const format, Args&& ...args) {
+ void
logDebug(fmt::format_string<std::invoke_result_t<decltype(core::logging::map_args),
Args>...> fmt, Args&& ...args) {
if (logger_)
- logger_->log_debug(format, std::forward<Args>(args)...);
+ logger_->log_debug(fmt, std::forward<Args>(args)...);
Review Comment:
👍
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/1708a25c1b0cbeae6de94ea6ec74986a00a6d3e6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
