martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342408998
##########
libminifi/include/core/logging/Logger.h:
##########
@@ -49,59 +50,15 @@ class LoggerControl {
std::atomic<bool> is_enabled_;
};
-template<typename Arg>
-using has_const_c_str_method = decltype(std::declval<const Arg&>().c_str());
-
template<typename Arg>
inline decltype(auto) conditional_stringify(Arg&& arg) {
- if constexpr (utils::meta::is_detected_v<has_const_c_str_method, Arg> ||
std::is_scalar_v<std::decay_t<Arg>>) {
- return std::forward<Arg>(arg);
- } else if constexpr (std::is_invocable_v<Arg>) {
+ if constexpr (std::is_invocable_v<Arg>) {
Review Comment:
You are right, this is just a leftover from the previous implementation
removed it in
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/0b82cf18a151400080017725bb97b925fe8d459d#diff-609cfbc9531d250927c98865424e809b582691daacc2d9540cfb857059eff348L54-L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
