szaszm commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342557733
##########
extensions/http-curl/protocols/RESTSender.cpp:
##########
@@ -183,12 +183,12 @@ C2Payload RESTSender::sendPayload(const std::string& url,
const Direction direct
const bool clientError = 400 <= respCode && respCode < 500;
const bool serverError = 500 <= respCode && respCode < 600;
if (clientError || serverError) {
- logger_->log_error("Error response code '" "%" PRId64 "' from '%s'",
respCode, url);
+ logger_->log_error("Error response code '{}' from '{}'", respCode, url);
} else {
- logger_->log_debug("Response code '" "%" PRId64 "' from '%s'", respCode,
url);
+ logger_->log_debug("Response code '{}' from '{}'", respCode, url);
}
const auto response_body_bytes =
gsl::make_span(client.getResponseBody()).as_span<const std::byte>();
- logger_->log_trace("Received response: \"%s\"", [&] {return
utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});
+ logger_->log_trace("Received response: {}", [&] { return
utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});
Review Comment:
I'd restore the quotes around the printed response
```suggestion
logger_->log_trace("Received response: \"{}\"", [&] { return
utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
