martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342410709
##########
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##########
@@ -628,7 +628,7 @@ void ConsumeWindowsEventLog::LogWindowsError(const
std::string& error) const {
(LPTSTR)&lpMsg,
0, nullptr);
- logger_->log_error((error + " %x: %s\n").c_str(),
static_cast<int>(error_id), reinterpret_cast<char *>(lpMsg));
+ logger_->log_error((error + " {:#x}: {}\n").c_str(),
static_cast<int>(error_id), reinterpret_cast<char *>(lpMsg));
Review Comment:
I've rewritten these windows error loggers in
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/e8110718c9932e43db1e1e133e983bcf8445d1c2
and
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/bcd685d4dcfa8c380c2fd4194fda168de05c88db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
