martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1342553887
##########
libminifi/src/FlowFileRecord.cpp:
##########
@@ -50,17 +50,17 @@ std::shared_ptr<FlowFileRecord>
FlowFileRecord::DeSerialize(const std::string& k
std::string value;
if (!flowRepository->Get(key, value)) {
- logger_->log_error("NiFi FlowFile Store event %s can not found", key);
+ logger_->log_error("NiFi FlowFile Store event {} can not found", key);
return nullptr;
}
io::BufferStream stream(value);
auto record = DeSerialize(stream, content_repo, container);
if (record) {
- logger_->log_debug("NiFi FlowFile retrieve uuid %s size " "%" PRIu64 "
connection %s success", record->getUUIDStr(), stream.size(),
container.to_string());
+ logger_->log_debug("NiFi FlowFile retrieve uuid {} size {} connection {}
success", record->getUUIDStr(), stream.size(), container.to_string());
} else {
- logger_->log_debug("Couldn't deserialize FlowFile %s from the stream of
size " "%" PRIu64, key, stream.size());
+ logger_->log_debug("Couldn't deserialize FlowFile {} from the stream of
size " "{}", key, stream.size());
Review Comment:
Nice catch, I've missed these. fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/e4f21d88ae2f0df7bd9f47a800fd2779f38a91a6
##########
libminifi/include/core/logging/Logger.h:
##########
@@ -234,33 +190,34 @@ class Logger : public BaseLogger {
std::mutex mutex_;
private:
+ std::string trimToMaxSizeAndAddId(std::string&& my_string) {
Review Comment:
Fixed in
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/fea09110f9e9c60abee47351c52a1cfec2d87d8a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
