fgerlits commented on code in PR #1708:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1426957069
##########
extensions/azure/processors/AzureBlobStorageProcessorBase.h:
##########
@@ -51,10 +51,13 @@ class AzureBlobStorageProcessorBase : public
AzureStorageProcessorBase {
.withDescription("The storage account key. This is an admin-like
password providing access to every container in this account. "
"It is recommended one uses Shared Access Signature (SAS) token
instead for fine-grained control with policies.")
.supportsExpressionLanguage(true)
+ .isSensitive(true)
.build();
EXTENSIONAPI static constexpr auto SASToken =
core::PropertyDefinitionBuilder<>::createProperty("SAS Token")
.withDescription("Shared Access Signature token. Specify either SAS
Token (recommended) or Storage Account Key together with Storage Account Name
if Managed Identity is not used.")
- .supportsExpressionLanguage(true).build();
+ .supportsExpressionLanguage(true)
Review Comment:
`onSchedule` only does a sanity check that `SASToken` is non-empty; in
`AzureBlobStorageProcessorBase::getAzureCredentialsFromProperties()` we use
`getProperty()` with a flow file argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
