szaszm commented on code in PR #1708:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1444537801
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -620,20 +628,26 @@ void StructuredConfiguration::parseRPGPort(const Node&
port_node, core::ProcessG
}
void StructuredConfiguration::parsePropertyValueSequence(const std::string&
property_name, const Node& property_value_node, core::ConfigurableComponent&
component) {
+ core::Property myProp(property_name, "", "");
+ component.getProperty(property_name, myProp);
+
for (const auto& nodeVal : property_value_node) {
if (nodeVal) {
Node propertiesNode = nodeVal["value"];
- // must insert the sequence in differently.
- const auto rawValueString = propertiesNode.getString().value();
- logger_->log_debug("Found {}={}", property_name, rawValueString);
+ auto rawValueString = propertiesNode.getString().value();
+ if (myProp.isSensitive()) {
+ rawValueString = decryptProperty(rawValueString);
+ }
+ logger_->log_debug("Found property {}", property_name);
Review Comment:
I don't think it's a big problem to break properties that use the `enc{`/`}`
wrappers on their own, but it's also not ideal. To limit the set of broken
property values, we could check the format of the string inside the wrapper,
and only act if it looks like what our encrypted values look.
Maybe it's best to leave it as is for now, and figure this out later if/when
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
