adamdebreceni commented on code in PR #1708: URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1444425152
########## libminifi/include/core/flow/StructuredConfiguration.h: ########## @@ -34,6 +34,8 @@ #include "utils/file/FileSystem.h" #include "core/flow/Node.h" #include "FlowSchema.h" +#include "rapidjson/document.h" +#include "yaml-cpp/yaml.h" Review Comment: although it would be nice not to have this this dependency here, I understand that it would require extra indirections/tests which would bloat this PR, could we create a ticket to tuck the clone/modification/save implementations away like we do with flow::Node? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
