EndzeitBegins commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526759912
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##########
@@ -110,6 +110,14 @@ private static String
convertFactorySetToString(Set<String> factorySetNames) {
.collect(Collectors.joining(", "));
}
+ private static String buildFullPath(String path, String filename) {
+ return (path == null) ? filename : (path.endsWith("/")) ? path +
filename : path + "/" + filename;
+ }
Review Comment:
Thank you for the review.
Yes, I thought about that myself, but figured I keep the changes to a
minimum.
However, I think you're right that this should be refactored. I replaced it
with an if statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
