mcgilman commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1541475885
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -2189,11 +2190,12 @@ export class FlowEffects {
ofType(FlowActions.showOkDialog),
tap((request) => {
this.dialog.open(OkDialog, {
+ ...MEDIUM_DIALOG,
+ maxWidth: '24rem',
Review Comment:
I see this is used in a few places. I believe with this set up the
`minWidth` is wider than the `maxWidth`. `SMALL_DIALOG` is already set to use
`24rem`. What was the intention here?
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##########
@@ -382,9 +383,9 @@ export class ControllerServicesEffects {
const serviceId: string = request.id;
const enableDialogReference =
this.dialog.open(EnableControllerService, {
+ ...XL_DIALOG,
data: request,
- id: serviceId,
- panelClass: 'large-dialog'
+ id: serviceId
Review Comment:
Was moving to XL dialog intentional? This appears to have been done to both
Enable and Disable dialogs.
<img width="1036" alt="Screenshot 2024-03-27 at 12 30 15 PM"
src="https://github.com/apache/nifi/assets/123395/dd52dbfc-b133-4174-8c9a-1fa5c2a4a203";>
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/purge-history/purge-history.component.html:
##########
@@ -34,7 +34,7 @@ <h2 mat-dialog-title>Purge History</h2>
<mat-datepicker #endDatePicker></mat-datepicker>
</mat-form-field>
</div>
- <div>
+ <div class="w-full">
Review Comment:
I don't _think_ was introduced here but these two fields are different
widths. Happy to file something though and we can fix later unless you want to
get it here.
<img width="509" alt="Screenshot 2024-03-27 at 12 25 28 PM"
src="https://github.com/apache/nifi/assets/123395/312eee5e-b29f-41af-b138-549d630183be";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
