scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1543461479
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##########
@@ -382,9 +383,9 @@ export class ControllerServicesEffects {
const serviceId: string = request.id;
const enableDialogReference =
this.dialog.open(EnableControllerService, {
+ ...XL_DIALOG,
data: request,
- id: serviceId,
- panelClass: 'large-dialog'
+ id: serviceId
Review Comment:
ok I gave this another shot using the basis-2/3 and basis-1/3. I think it
works well. There were some other text overflow issues I had to address for
these dialogs but I was able to use the LARGE_DIALOG,
`.basis-2/3`/`.basis-1/3`, text ellipsis, and remove the height to reduce the
amount of unused space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
