rfellows commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1542835501


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##########
@@ -382,9 +383,9 @@ export class ControllerServicesEffects {
                     const serviceId: string = request.id;
 
                     const enableDialogReference = 
this.dialog.open(EnableControllerService, {
+                        ...XL_DIALOG,
                         data: request,
-                        id: serviceId,
-                        panelClass: 'large-dialog'
+                        id: serviceId

Review Comment:
   Should we be using the `basis-2/3`. and `basis-1/3` here to make the left 
side larger than the right? Seems like we probably don't need half of the space 
for the referencing components here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to