lordgamez commented on PR #1749: URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#issuecomment-2101286514
> @szaszm I agree **MINIFI_OPENSSL** and **ENABLE_CURL** should now no longer be minifi_options, they must be enabled in order to successfully build libminifi. However, for the case of building libarchive, we can build libarchive with openssl enabled set to true or false. Did you make it mandatory for minifi extensions that use openssl? > > In my PR-1775 for MINIFICPP-2346: I do note about the critical minifi options that must be enabled to successfully build libminifi. I found that **ENABLE_OPENWSMAN, ENABLE_CIVET** must also be ON for libminifi to build succssfully. Those 4 minifi options are the minimum to build libminifi C++ core-minifi, mainexe and standard processors. > > * I also mention about the options that must be enabled to build GTESTs. Furthermore, I am wrapping up testing enabling all the remaining extension. @james94 how did you find the ENABLE_OPENWSMAN must be ON for libminifi build to succeed? I managed to build it successfully without it and it should be a separate extension that should not have any effect on the core libminifi. We also had some discussions in the past if civetweb should be part of the core libminifi, but we decided not to due to the following reasons: - It is not actually required by core libminifi, it is only needed for the tests and some of the extensions. If you build libminifi with SKIP_TESTS=ON and turn off civetweb extension the libminifi should build successfully - We had some concerns about the civetweb codebase so we may replace it in the future with a different library, so we would rather not include it in the core libminifi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
