szaszm commented on code in PR #1749: URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1603324425
########## libminifi/include/utils/TimeUtil.h: ########## @@ -42,6 +42,10 @@ #include "date/date.h" +#ifdef WIN32 +#include "date/tz.h" +#endif Review Comment: Why is this windows-only? The `dateSetInstall` function declaration doesn't use anything from this header, so if that's the culprit, then this include should be moved to the cpp file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
