mcgilman commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1573292418


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##########
@@ -155,9 +155,9 @@ export class ControllerServiceTable {
             return 'invalid fa fa-warning';
         } else {
             if (entity.status.runStatus === 'DISABLED') {
-                return 'disabled primary-color icon icon-enable-false';
+                return 'disabled on-surface-default icon icon-enable-false';

Review Comment:
   This change looks good for services that are part of the flow but the state 
icon for management services is not updated.



##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/editors/nf-editor/_nf-editor.component-theme.scss:
##########
@@ -31,17 +31,21 @@
     // Get hues from palette
     $material-theme-primary-palette-lighter: 
mat.get-color-from-palette($material-theme-primary-palette, lighter);
     $material-theme-primary-palette-default: 
mat.get-color-from-palette($material-theme-primary-palette, default);
-    $nifi-theme-surface-palette-400-contrast: 
mat.get-color-from-palette($nifi-theme-surface-palette, '400-contrast');
+    $nifi-theme-surface-palette-default-contrast: mat.get-color-from-palette(
+        $nifi-theme-surface-palette,
+        'default-contrast'
+    );
     $nifi-theme-surface-palette-default: 
mat.get-color-from-palette($nifi-theme-surface-palette, default);
-    $surface: utils.get-surface($nifi-theme-color-config);
+    $nifi-theme-surface-palette-lighter: 
mat.get-color-from-palette($nifi-theme-surface-palette, 'lighter');
     $on-surface: utils.get-on-surface($nifi-theme-color-config);
+    $on-surface-lighter: utils.get-on-surface($nifi-theme-color-config, 
lighter);
 
     .property-editor {
         @include mat.button-density(-1);
 
         .nf-editor {
             .CodeMirror {
-                background-color: $surface;
+                background-color: $nifi-theme-surface-palette-lighter;

Review Comment:
   Not relating this to line but is there anything we can do with the color of 
the gutter in dark mode? It is very bright compared to it's surroundings.
   
   <img width="506" alt="Screenshot 2024-04-20 at 9 58 38 AM" 
src="https://github.com/apache/nifi/assets/123395/f43389c9-60b6-4cfd-a099-2add28781f62";>
   



##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/_new-canvas-item.component-theme.scss:
##########
@@ -26,20 +26,18 @@
 
     // Get the color palette from the color-config.
     $material-theme-primary-palette: map.get($material-theme-color-config, 
'primary');
+    $nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
 
     // Get hues from palette
-    $surface-darker: utils.get-surface($nifi-theme-color-config, darker);
     $on-surface-highlight: utils.get-on-surface($nifi-theme-color-config, 
highlight);
     $on-surface-lighter: utils.get-on-surface($nifi-theme-color-config, 
lighter);
-
-    // Use the same logic as _navigation.component-theme.scss to determine the 
bg color for hover
-    $hover-bg: mat.get-color-from-palette($material-theme-primary-palette, 
'navbar');
-    @if ($hover-bg) {
-        // Nothing to do here, we have special color from the palette.
-    } @else {
-        // There was not a special value set for the navbar, so we use Angular 
Material behavior.
-        $hover-bg: mat.get-color-from-palette($material-theme-primary-palette, 
'default');
-    }
+    $is-dark: map-get($material-theme-color-config, is-dark);

Review Comment:
   Not relating to this line directly, in dark mode I do not think there is 
enough differentiation in the enabled and disabled state of the draggable icons.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to