scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1574851802
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/editors/nf-editor/_nf-editor.component-theme.scss:
##########
@@ -31,17 +31,21 @@
// Get hues from palette
$material-theme-primary-palette-lighter:
mat.get-color-from-palette($material-theme-primary-palette, lighter);
$material-theme-primary-palette-default:
mat.get-color-from-palette($material-theme-primary-palette, default);
- $nifi-theme-surface-palette-400-contrast:
mat.get-color-from-palette($nifi-theme-surface-palette, '400-contrast');
+ $nifi-theme-surface-palette-default-contrast: mat.get-color-from-palette(
+ $nifi-theme-surface-palette,
+ 'default-contrast'
+ );
$nifi-theme-surface-palette-default:
mat.get-color-from-palette($nifi-theme-surface-palette, default);
- $surface: utils.get-surface($nifi-theme-color-config);
+ $nifi-theme-surface-palette-lighter:
mat.get-color-from-palette($nifi-theme-surface-palette, 'lighter');
$on-surface: utils.get-on-surface($nifi-theme-color-config);
+ $on-surface-lighter: utils.get-on-surface($nifi-theme-color-config,
lighter);
.property-editor {
@include mat.button-density(-1);
.nf-editor {
.CodeMirror {
- background-color: $surface;
+ background-color: $nifi-theme-surface-palette-lighter;
Review Comment:
We absolutely can! I have pushed some updates here in my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]