scottyaslan commented on PR #8663:
URL: https://github.com/apache/nifi/pull/8663#issuecomment-2072393868

   > There are some discrepancies between light and dark mode in terms of 
bulletin/warn styling. In light mode the bulletin icon for the canvas and for 
processors (and most likely other components) looks good. They use the 
`warn-color-darker` background with a white color for the icon. However, in 
dark mode it seems this is not respected and `red` is used as the background 
and the icon color is white for the canvas but black for the processor. <img 
alt="Screenshot 2024-04-23 at 8 24 05 AM" width="1151" 
src="https://private-user-images.githubusercontent.com/713866/324832248-e07d9da9-8a73-4cbe-ac46-2b668a72e6eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMyMjQ4LWUwN2Q5ZGE5LThhNzMtNGNiZS1hYzQ2LTJiNjY4YTcyZTZlYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJT
 
JGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NTVkYmIzNjc3ZDFjODc0ZDM4YjMyZGM1NWVjMmZkNTQzMWU3MzMzYzZhZWQxZWFhMTE1ZTc5MjVjZDU1ZjhmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zmjgnsRKg0HF2Pv29dp70i9RTJ5PDuMu_MQ-FGSKNz4">
 <img alt="Screenshot 2024-04-23 at 8 23 52 AM" width="1157" 
src="https://private-user-images.githubusercontent.com/713866/324832281-ebc42446-cc7f-46d8-96c1-caaf53722a9d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMyMjgxLWViYzQyNDQ2LWNjN2YtNDZkOC05NmMxLWNhYWY1MzcyMmE5ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNp
 
Z25hdHVyZT03Mjc5YzUwODFmNTg4NzA1OGE5NDMyNDQ5Yjk3Nzk1ZGM0MWRlZjBhMmRlNTVhNmY3MmFlYzQzYTFhYmRmYzk1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.K86DCONJq_KrIj-eWosVGbRuvHVFkEC4Yai_bqVowvw">
   > 
   
   Good catch! The red background colors are correct AFAIK. I will update the 
bulletin icon color.
   
   > Also of note, the cluster nodes icon in the top left is no longer 
indicating a problem when a node is not available. This used to display in the 
darker warning color, now it doesn't seem to have a color at all (black). This 
is how it looks in original NiFi: <img alt="Screenshot 2024-04-23 at 8 30 47 
AM" width="237" 
src="https://private-user-images.githubusercontent.com/713866/324833245-8a1373f0-444a-4274-be7e-d61908a78eee.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMzMjQ1LThhMTM3M2YwLTQ0NGEtNDI3NC1iZTdlLWQ2MTkwOGE3OGVlZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MmFlOGZkZGYyZTBhMTg2ZDlkNDAxY2FiN2RkY2YzMzc2M2JkMDgwNDc2NjBh
 
NzVhNWVhZjQ5M2I3OTBlZGU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.kiXGJAOGDlAHbEXkBp_BbaqXwxe3Gbk--jmNb9icpoo">
 vs how it looks now: <img alt="Screenshot 2024-04-23 at 8 31 47 AM" 
width="231" 
src="https://private-user-images.githubusercontent.com/713866/324833443-635e998a-4380-44c9-9239-3aa38be03c7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4ODA3ODMsIm5iZiI6MTcxMzg4MDQ4MywicGF0aCI6Ii83MTM4NjYvMzI0ODMzNDQzLTYzNWU5OThhLTQzODAtNDRjOS05MjM5LTNhYTM4YmUwM2M3ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyM1QxMzU0NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGY0ZTQ2NWI3NzdiYWNhZWQyYWM1YTA1YTk4Y2NiZjgyNTIwNmZmMzczOGMxYTE2ZjMxOGQ1OWVhM2Q1YzlkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faW
 Q9MCJ9.ntlhEYbC4AfxA55reupZvuhlbzmfjdjvOxFjDnF1HyE">
   
   Another great catch! I have updated the warning color of the clustered icon 
in the flow status menu to be the nifi (theme) warn (palette) darker color.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to