bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587909319
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/FlowAnalyzingRegistryClientNode.java:
##########
@@ -401,13 +401,33 @@ public boolean isStorageLocationApplicable(final String
location) {
}
@Override
- public Set<FlowRegistryBucket> getBuckets(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
- return node.getBuckets(context);
+ public boolean isBranchingSupported() {
+ return node.isBranchingSupported();
}
@Override
- public FlowRegistryBucket getBucket(final FlowRegistryClientUserContext
context, final String bucketId) throws FlowRegistryException, IOException {
- return node.getBucket(context, bucketId);
+ public Set<FlowRegistryBranch> getBranches(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+ return node.getBranches(context);
+ }
+
+ @Override
+ public FlowRegistryBranch getDefaultBranch(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+ return node.getDefaultBranch(context);
+ }
+
+ @Override
+ public void createBranch(final FlowRegistryClientUserContext context,
final CreateBranch createBranch) throws FlowRegistryException, IOException {
Review Comment:
The `CreateBranch` object is still just a data driven pojo just like
`RegisteredFlow`. I am happy to name it something that sounds less like a
command, maybe just adding `Info` to the end - `CreateBranchInfo` ?
I originally had the method as `createBranch(context, String fromBranch,
String toBranch)`, but I made the arguments an object following similar
thinking to the location objects, meaning - in the future if we have to add
another argument, we don't have to break the API signature of `createBranch`,
we just add another field to the `CreateBranch` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
