simonbence commented on code in PR #8726: URL: https://github.com/apache/nifi/pull/8726#discussion_r1588977169
########## nifi-api/src/main/java/org/apache/nifi/registry/flow/BucketLocation.java: ########## @@ -0,0 +1,54 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one or more + * * contributor license agreements. See the NOTICE file distributed with + * * this work for additional information regarding copyright ownership. + * * The ASF licenses this file to You under the Apache License, Version 2.0 + * * (the "License"); you may not use this file except in compliance with + * * the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.nifi.registry.flow; + +/** + * Information for locating a bucket in a flow registry. + */ +public class BucketLocation { + + private String branch; Review Comment: Thank you for describing it in detail! The create branch related features misled me a bit. I was thinking we want to cover the "branch management" part of the lifecycle within NiFi UI. If that is not the case, please ignore my concerns, the workflow you want to cover seems just right. In case however we want to involve the branch management into NiFi (UI), I think it will need some further consideration (like adding support for breating buckets as well, or alike). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
