bbende commented on code in PR #8726: URL: https://github.com/apache/nifi/pull/8726#discussion_r1587922187
########## nifi-api/src/main/java/org/apache/nifi/registry/flow/CreateBranch.java: ########## @@ -0,0 +1,53 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one or more + * * contributor license agreements. See the NOTICE file distributed with + * * this work for additional information regarding copyright ownership. + * * The ASF licenses this file to You under the Apache License, Version 2.0 + * * (the "License"); you may not use this file except in compliance with + * * the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.nifi.registry.flow; + +/** + * Information for creating a branch in a flow registry. + */ +public class CreateBranch { + + private String fromBranch; + private String newBranch; + + public CreateBranch() { + } + + public CreateBranch(final String fromBranch, final String newBranch) { + this.fromBranch = fromBranch; Review Comment: That was my current thinking, but you are right that possibly having a commit to branch from would make sense. I will consider adding this if we decide to keep this method based on discussion in other comment about where this should be done outside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
