exceptionfactory commented on code in PR #8782:
URL: https://github.com/apache/nifi/pull/8782#discussion_r1595365571
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/index/lucene/LuceneEventIndex.java:
##########
@@ -182,14 +182,7 @@ private void triggerReindexOfDefunctIndices() {
for (final File defunctIndex : defunctIndices) {
try {
- if (isLucene4IndexPresent(defunctIndex)) {
- logger.info("Encountered Lucene 8 index {} and also the
corresponding Lucene 4 index; will only trigger rebuilding of one directory.",
defunctIndex);
- rebuildCount.incrementAndGet();
- continue;
- }
Review Comment:
This rebuild step is no longer required?
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/pom.xml:
##########
@@ -46,16 +46,6 @@
<artifactId>lucene-core</artifactId>
<version>${lucene.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-analyzers-common</artifactId>
- <version>${lucene.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-queryparser</artifactId>
- <version>${lucene.version}</version>
- </dependency>
Review Comment:
Is there a particular reason for removing these two dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
