joewitt commented on code in PR #8782:
URL: https://github.com/apache/nifi/pull/8782#discussion_r1595491134
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/index/lucene/LuceneEventIndex.java:
##########
@@ -182,14 +182,7 @@ private void triggerReindexOfDefunctIndices() {
for (final File defunctIndex : defunctIndices) {
try {
- if (isLucene4IndexPresent(defunctIndex)) {
- logger.info("Encountered Lucene 8 index {} and also the
corresponding Lucene 4 index; will only trigger rebuilding of one directory.",
defunctIndex);
- rebuildCount.incrementAndGet();
- continue;
- }
Review Comment:
We don't actually support or need to support the Lucene4 style indexes
anymore at all so I removed that. I kept the lucene4 example test files but
renamed their structure to look like lucene8 style. In short - no we only have
to deal with Lucene8 or greater style indexes/naming now. I read on Lucene's
site the backward code only handles one major version change anyway (not sure
if true/etc..) but either way we're long gone from Lucene4 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
