joewitt commented on code in PR #8782:
URL: https://github.com/apache/nifi/pull/8782#discussion_r1595488802
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/pom.xml:
##########
@@ -46,16 +46,6 @@
<artifactId>lucene-core</artifactId>
<version>${lucene.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-analyzers-common</artifactId>
- <version>${lucene.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-queryparser</artifactId>
- <version>${lucene.version}</version>
- </dependency>
Review Comment:
@exceptionfactory They used to be in this depMgmt section and actually
dependened on the in the persistent prov repo. However, in the great
dependency destruction JIRA of last month they were (plus
lucene-backward-codecs) found to be in no apparent way used.
I was notified by another user that they upgraded from the pre Lucene9 to
post Lucene9 and it broke lacking that lucene-backward-codec. So I restored
that one as runtime scope. Then spent a good bit of time reading about these
two. There are some SPI mechanisms in Lucene but no documentation or code
linkage I could find suggested we use need these. I also checkwith Payne and
he was suspected they used to be referenced and are not now.
So they're gone until we can show we actually need them. A full build of
nifi without them appears to work well including searching with wildcards/etc...
Our integration tests don't actually exercise the backward code at this
point. That was verified now manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
