mcgilman commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1601646400
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/component-state/component-state.component.html:
##########
@@ -48,6 +47,9 @@ <h2 mat-dialog-title>Component State</h2>
}
}
</div>
+ <div class="pt-1 accent-color font-medium">
+ Displaying {{ filteredEntries }} of {{ totalEntries }}
+ </div>
Review Comment:
This doesn't look quite right.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##########
@@ -23,37 +23,43 @@
} @else {
@if (policyComponentState$ | async; as policyComponentState) {
@if (flowConfiguration$ | async; as flowConfiguration) {
- <div class="component-access-policies flex flex-col h-full
gap-y-2">
+ <div class="component-access-policies flex flex-col h-full">
<error-banner></error-banner>
- <div class="accent-color font-medium">
- <div class="mb-2">
- @switch (accessPolicyState.policyStatus) {
- @case (PolicyStatus.NotFound) {
- No policy for the specified resource.
- @if
(flowConfiguration.supportsConfigurableAuthorizer) {
- <a
(click)="createNewPolicy()">Create</a> a new policy.
+ @if (
+ accessPolicyState.policyStatus ===
PolicyStatus.NotFound ||
+ accessPolicyState.policyStatus ===
PolicyStatus.Inherited ||
+ accessPolicyState.policyStatus ===
PolicyStatus.Forbidden
+ ) {
+ <div class="accent-color font-medium pb-3">
+ <div>
+ @switch (accessPolicyState.policyStatus) {
+ @case (PolicyStatus.NotFound) {
+ No policy for the specified resource.
Review Comment:
Should the access policy status be shown as a `hint` too?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/error-banner/error-banner.component.html:
##########
@@ -16,18 +16,20 @@
-->
@if ((messages$ | async)!; as messages) {
- <div class="banner-container border-t border-b px-6 py-3 flex
justify-between items-center">
- @if (messages.length === 1) {
- <div>{{ messages[0] }}</div>
- } @else {
- <ul>
- @for (message of messages; track message) {
- <li>{{ message }}</li>
- }
- </ul>
- }
- <div class="flex flex-col mt-auto">
- <button mat-stroked-button (click)="dismiss()">Dismiss</button>
+ <div class="pt-4 pb-4">
Review Comment:
```suggestion
<div class="py-4">
```
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/ui/common/cluster-table-filter/cluster-table-filter.component.ts:
##########
@@ -42,7 +42,7 @@ export interface ClusterTableFilterContext extends
ClusterTableFilterArgs {
@Component({
selector: 'cluster-table-filter',
standalone: true,
- imports: [MatCheckbox, MatFormField, MatInput, MatLabel, MatOption,
MatSelect, ReactiveFormsModule],
+ imports: [MatCheckbox, MatFormField, MatInput, MatLabel, MatOption,
MatSelect, ReactiveFormsModule, MatHint],
Review Comment:
`MatHint` is being imported but I'm not sure it's being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
