mcgilman commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1605475961
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##########
@@ -83,6 +55,37 @@
</mat-form-field>
</div>
</div>
+ <div class="accent-color font-medium py-2">
+ <div>
+ @switch (accessPolicyState.policyStatus) {
+ @case (PolicyStatus.NotFound) {
+ No policy for the specified
resource.
+ @if
(flowConfiguration.supportsConfigurableAuthorizer) {
+ <a
(click)="createNewPolicy()">Create</a> a new policy.
+ }
+ }
+ @case (PolicyStatus.Inherited) {
+ @if
(accessPolicyState.accessPolicy) {
+ <ng-container
+ *ngTemplateOutlet="
+
getTemplateForInheritedPolicy(accessPolicyState.accessPolicy);
+ context: {
+ $implicit:
accessPolicyState.accessPolicy,
+
supportsConfigurableAuthorizer:
+
flowConfiguration.supportsConfigurableAuthorizer
+ }
+ "></ng-container>
+ }
+ }
+ @case (PolicyStatus.Forbidden) {
+ Not authorized to access the
policy for the specified resource.
+ }
+ @default {
+ Displaying all authorized
Users/Groups
+ }
Review Comment:
I don't think we should be rendering anything in this condition. When the
authorized user listing is rendered it is never filtered, so I don't think we
need to indicate that all authorized Users/Groups are being displayed.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.html:
##########
@@ -37,6 +37,7 @@
</mat-form-field>
</div>
</div>
+ <div class="accent-color font-medium py-2 invisible"> </div>
Review Comment:
Rather than needing an empty element with ` ` can we just add some
equivalently sized spacing between the elements?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##########
@@ -83,6 +55,37 @@
</mat-form-field>
</div>
</div>
+ <div class="accent-color font-medium py-2">
+ <div>
+ @switch (accessPolicyState.policyStatus) {
+ @case (PolicyStatus.NotFound) {
+ No policy for the specified
resource.
+ @if
(flowConfiguration.supportsConfigurableAuthorizer) {
+ <a
(click)="createNewPolicy()">Create</a> a new policy.
+ }
+ }
+ @case (PolicyStatus.Inherited) {
+ @if
(accessPolicyState.accessPolicy) {
+ <ng-container
+ *ngTemplateOutlet="
+
getTemplateForInheritedPolicy(accessPolicyState.accessPolicy);
+ context: {
+ $implicit:
accessPolicyState.accessPolicy,
+
supportsConfigurableAuthorizer:
+
flowConfiguration.supportsConfigurableAuthorizer
+ }
+ "></ng-container>
+ }
+ }
+ @case (PolicyStatus.Forbidden) {
+ Not authorized to access the
policy for the specified resource.
+ }
+ @default {
+ Displaying all authorized
Users/Groups
+ }
Review Comment:
This comment applies to both the Global and Component policy page.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/feature/settings.component.html:
##########
@@ -35,7 +35,7 @@ <h3 class="primary-color">NiFi Settings</h3>
}
</nav>
</div>
- <div class="pt-4 flex-1">
+ <div class="pt-5 flex-1">
Review Comment:
This looks ok for the General tab but appears to be too much padding for
tabs that include tables.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/flow-configuration-history-listing.component.html:
##########
@@ -89,6 +89,7 @@
<a (click)="resetFilter($event)">Clear
Filter</a>
</div>
</div>
+ <div class="accent-color font-medium pt-2
invisible"> </div>
Review Comment:
Rather than needing an empty element with ` ` can we just add some
equivalently sized spacing between the elements?
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/ui/common/cluster-table-filter/cluster-table-filter.component.html:
##########
@@ -38,5 +35,6 @@
</mat-form-field>
</div>
</div>
+ <div class="py-2 accent-color font-medium">Filter matched {{
filteredCount }} of {{ totalCount }}</div>
Review Comment:
The spacing here is off compared with the other pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
